Skip to content

python3Packages.ipython: disable clipboard test on darwin (targeting master)#162047

Merged
siraben merged 1 commit intoNixOS:masterfrom
veprbl:pr/ipython_darwin_fix
Feb 27, 2022
Merged

python3Packages.ipython: disable clipboard test on darwin (targeting master)#162047
siraben merged 1 commit intoNixOS:masterfrom
veprbl:pr/ipython_darwin_fix

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 27, 2022

To be reverted on staging-next
cc #161366

Motivation for this change

Fixes: #160133

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 27, 2022
@veprbl veprbl mentioned this pull request Feb 27, 2022
Merged
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 27, 2022
@ofborg ofborg bot requested a review from bjornfor February 27, 2022 05:50
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 27, 2022
toonn
toonn approved these changes Feb 27, 2022
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I would do too, rather than stubbing out a fake pbcopy/pbpaste.

@siraben
Copy link
Member

siraben commented Feb 27, 2022

I'm running into issues with ipython being broken on darwin, I'll merge for now and we'll revert on staging-next.

@siraben siraben merged commit ae2d620 into NixOS:master Feb 27, 2022
veprbl added a commit that referenced this pull request Feb 28, 2022
@veprbl
Revert "python3Packages.ipython: disable clipboard test on darwin (ta…
403faa7 
…rgeting master)"

This reverts commit 6e1e1dd.

cc #162047
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jun 1, 2023
@veprbl @jsoo1
Revert "python3Packages.ipython: disable clipboard test on darwin (ta…
bcd1eaf 
…rgeting master)"

This reverts commit 6e1e1dd.

cc NixOS#162047
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jul 14, 2023
@veprbl @jsoo1
Revert "python3Packages.ipython: disable clipboard test on darwin (ta…
291c412 
…rgeting master)"

This reverts commit 6e1e1dd.

cc NixOS#162047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toonn toonn toonn approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python3Packages.ipython is failing on x86_64-darwin (master)

3 participants

@veprbl @siraben @toonn