Skip to content

openrussian-cli: refactor to use lua.withPackages#161396

Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
vs49688:orfix
Mar 15, 2022
Merged

openrussian-cli: refactor to use lua.withPackages#161396
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
vs49688:orfix

Conversation

@vs49688
Copy link
Contributor

@vs49688 vs49688 commented Feb 22, 2022 •
edited
Loading

Motivation for this change

Refactor to use lua.withPackages instead of luaPackages.

Do NOT apply until #161366 is merged.

Changed to target staging-next as #161366 has been blocked for so long.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ x Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 22, 2022
@talyz
Copy link
Contributor

talyz commented Feb 22, 2022

As stated in #161375, the wrapProgram issue is fixed and should not need to be worked around once the fix reaches master. It's also not needed in stable, since the commit that introduced the bug was never backported.

@vs49688 vs49688 changed the title openrussian-cli: fix "module 'luasql.sqlite3' not found" openrussian-cli: refactor to use lua.withPackages Feb 23, 2022
@vs49688
Copy link
Contributor Author

vs49688 commented Feb 23, 2022

Cool, I've updated the PR to only include the refactor and removed the backport label.

@vs49688 vs49688 changed the base branch from master to staging-next March 9, 2022 06:14
@vs49688
Copy link
Contributor Author

vs49688 commented Mar 9, 2022

ping on this?

@vs49688 vs49688 requested a review from bobby285271 March 12, 2022 16:01
@vs49688 vs49688 mentioned this pull request Mar 14, 2022
Closed
@vs49688 vs49688 requested review from SuperSandro2000 and removed request for bobby285271 March 14, 2022 23:43
@SuperSandro2000 SuperSandro2000 merged commit a31cb90 into NixOS:staging-next Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vs49688 @talyz @SuperSandro2000