@ofborg eval

Successfully created backport PR #160897 for staging-21.11.

Perhaps we'd be better off spending our testing effort on 21.11...

Perhaps we'd be better off spending our testing effort on 21.11...

Could you elaborate?

We're doing the bump in staging-21.11 too, and it's possible that it'll hit real users there (i.e. make it to release-21.11) before this makes it in to master. So I'll be doing some testing on #160897. That's all.

Bisect says perlPackages.XMLParser is broken by 62b1a57 expat: 2.4.4 -> 2.4.5 (security):

$ nix build -f. perlPackages.XMLParser -L
...
perl5.34.0-XML-Parser> #   Failed test at t/decl.t line 86.
perl5.34.0-XML-Parser> #          got: '((bar|foo|xyz+),bar)'
perl5.34.0-XML-Parser> #     expected: '((bar|foo|xyz+),zebra*)'
perl5.34.0-XML-Parser> #   Failed test at t/decl.t line 95.
perl5.34.0-XML-Parser> #          got: 'bar'
perl5.34.0-XML-Parser> #     expected: 'zebra'
perl5.34.0-XML-Parser> #   Failed test at t/decl.t line 96.
perl5.34.0-XML-Parser> #          got: undef
perl5.34.0-XML-Parser> #     expected: '*'
perl5.34.0-XML-Parser> # Looks like you failed 3 tests of 40.

@trofi can you help me find that test case so I can debug this in Expat?

https://metacpan.org/release/TODDR/XML-Parser-2.46/source/t/decl.t#L86

Thanks!

Next time it would be better to debug this first instead of leaving staging in a totally broken state.

also @hartwork you might want to add yourself to meta.maintainers.

PS: Why do we not have an extra tag for upstream developers which also maintain the package?

Or on GitHub https://github.com/toddr/XML-Parser/blob/master/t/decl.t#L86 . Repo seams to be pretty dead.

also @hartwork you might want to add yourself to meta.maintainers.

@SuperSandro2000 I'm not really maintaining the package and I have enough to do upstream already. I originally jumped in with Expat package updates at #124212 because Expat was badly out of date in NixOS at the time. Maybe it's best if I take my hands back off this package and someone else takes over.

I don't think staging is totally broken by this. And I did test libxml2 (and the stdenv rebuild) before merging.

Seconded - I've been building many, many packages without issue.

perlPackages.XMLParser is in the dependency chain of nix through mdbook, cargo, git, openssh, libfido2, systemd-minimal, intltool and perl XML-Parser and the ofborg-eval-lib-tests currently fail because of that which means every PR against staging is red.

Maybe it's best if I take my hands back off this package and someone else takes over.

Not your fault that perlPackages.XMLParser is broken.

Anyone has any idea how to fix it? Is it just the test or code used by other things? Otherwise we need to revert this update until someone can fix it because right now every PR is red and normally can't be merged and staging would never advance.

Anyone has any idea how to fix it? Is it just the test or code used by other things?

I'm at it. I'll need more time.

Mental note: this is the sort of case where adding perlPackages.XMLParser to expat's passthru.tests would help us make sure it gets tested next time.

Mental note: this is the sort of case where adding perlPackages.XMLParser to expat's passthru.tests would help us make sure it gets tested next time.

I'm at it. I'll need more time.

The regression turned out real, there is a fix, a new regression test, a new release 2.4.6 upstream, and a NixOS pull request #161090 to bump to 2.4.6.

Thank you, Sebastian!

@trofi thanks for the report!

Would you like us to set up a full nixpkgs rebuild as your expat project CI? It would only take a few weeks per commit...

@risicle I think I need to respectfully decline 😃 (If there is a serious bit in there, let's take it to e-mail please.)