Minor fixes for emptyValues#160487
Merged
infinisil merged 2 commits intoNixOS:masterfrom Feb 22, 2022
Merged
Conversation
7 tasks
roberth
approved these changes
Feb 17, 2022
lib/types.nix
Outdated
Member
There was a problem hiding this comment.
Suggested change
| emptyValue = { }; | |
| emptyValue = { }; # no .value attr, meaning unset |
nitpick: fight the misunderstanding that the empty value would be { } here.
Member
Author
There was a problem hiding this comment.
Good idea, pushed this change
An empty list is [], not {}!
Also, non-empty lists shouldn't have a default of an empty list!
infinisil
force-pushed
the
emptyValueFixes
branch
from
3386579 to
b333395
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Split off from #132448 since it's mostly separate change.
This fixes two
emptyValuevalues and adds some test cases foremptyValues.Originally I also wanted to use these
emptyValue's as defaults when nodefaultis specified for an option, but I think that might not be a great idea.Things done
lib/tests/modules.sh