stdenv/check-meta: remove onlyLicenses check#160467
Merged
roberth merged 1 commit intoNixOS:masterfrom Mar 7, 2022
Merged
Conversation
Contributor
|
So, making sure that the license is a known license is not desirable? |
Member
Author
|
The nixpkgs manual says this:
In any case, this check isn't ensuring that |
Contributor
|
ah right. 👍 then. |
wmertens
approved these changes
Feb 17, 2022
Member
Author
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154031. I could not find a reason for this check to exist and @wmertens has not replied.
meta.licenseneeds not be an attribute oflib.licenses, so allow/blocklists should not either.cc @ony @roberth