Skip to content

python3Packages.semantic-version: 2.8.5 -> 2.9.0#159557

Merged
fabaff merged 2 commits intoNixOS:stagingfrom
fabaff:bump-semantic-version
Feb 15, 2022
Merged

python3Packages.semantic-version: 2.8.5 -> 2.9.0#159557
fabaff merged 2 commits intoNixOS:stagingfrom
fabaff:bump-semantic-version

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Feb 12, 2022

Motivation for this change

https://github.com/rbarrois/python-semanticversion/blob/master/ChangeLog#290-2022-02-06

Enable tests

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 12, 2022
@ofborg ofborg bot requested review from layus and makefu February 12, 2022 14:12
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 12, 2022
@fabaff
Copy link
Member Author

fabaff commented Feb 13, 2022 •
edited
Loading

One for staging...

@fabaff fabaff force-pushed the bump-semantic-version branch from fc64884 to c25c255 Compare February 14, 2022 08:43
@fabaff fabaff changed the base branch from master to staging February 14, 2022 08:43
@ofborg ofborg bot requested review from layus and makefu February 14, 2022 10:24
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft labels Feb 14, 2022
layus
layus approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, nothing special in there, so +1 for me, and thanks for making the tests pass.
I just wonder if we area ready to make semantic-version python >= 3.7 only, or if we should keep a separate, older version for old python packages around. I guess @FRidh and @jonringer will have a better picture about this.

@fabaff fabaff force-pushed the bump-semantic-version branch from c25c255 to 5f3dfcf Compare February 15, 2022 08:11
@ofborg ofborg bot removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Feb 15, 2022
@ofborg ofborg bot requested a review from layus February 15, 2022 08:29
@fabaff
Copy link
Member Author

fabaff commented Feb 15, 2022

We can always add support for < 3.7 if needed. Everything below 3.7 is EOL and the approx. 10 packages which requires semantic-version in Nixpkgs should be fine as far as I can tell.

layus
layus approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always add support for < 3.7 if needed. Everything below 3.7 is EOL and the approx. 10 packages which requires semantic-version in Nixpkgs should be fine as far as I can tell.

Oh, right. I thought it was more used. I guess it is just fine then. Thanks for targeting staging.

@fabaff fabaff merged commit 4639059 into NixOS:staging Feb 15, 2022
@fabaff fabaff deleted the bump-semantic-version branch February 15, 2022 11:54
@kirillrdy
Copy link
Member

kirillrdy commented Mar 16, 2022

this breaks awsebcli

I have a fix here #164336

can some one have a look ?

Cheers,

@kirillrdy kirillrdy mentioned this pull request Mar 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layus layus layus approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@makefu makefu Awaiting requested review from makefu

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @kirillrdy @layus