python3Packages.furo: fix build#159255
Merged
dotlambda merged 1 commit intoNixOS:masterfrom Feb 12, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: python
This was referenced Feb 11, 2022
ofborg
bot
added
11.by: package-maintainer
jonringer
approved these changes
Feb 11, 2022
Contributor
There was a problem hiding this comment.
not ideal, but better than having to do the node packaging ourselves.
Contributor
Author
There was a problem hiding this comment.
Yeah, I don't know what else to do.
dotlambda
reviewed
Feb 11, 2022
furo requires webpack since version 2021.11.12 and was recently updated in 7b890d5. Without this dependency, the built package is broken as it is missing some important files. This can be seen when trying to build kitty on Linux. webpack doesn't work correctly in nixpkgs, see NixOS#42275. I wasn't able to fix this. To make furo build correctly again despite the broken webpack, I switched to fetching the wheel instead of the source from PyPI, which has the necessary files already generated. I also added a small test to make sure that this directory won't be empty again in the future.
Luflosi
force-pushed
the
update/python3Packages.furo
branch
from
42871bb to
a0e9b56
Compare
Member
|
Result of 3 packages built:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
furo requires webpack since version 2021.11.12 and was recently updated in 7b890d5. Without this dependency, the built package is broken as it is missing some important files. This can be seen when trying to build kitty on Linux. webpack doesn't work correctly in nixpkgs, see #42275. I wasn't able to fix this.
To make furo build correctly again despite the broken webpack, I switched to fetching the wheel instead of the source from PyPI, which has the necessary files already generated.
I also added a small test to make sure that this directory won't be empty again in the future.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes