Skip to content

speex: patch zero division vector in wave header parser#158978

Merged
risicle merged 1 commit intoNixOS:stagingfrom
mweinelt:speex
Feb 15, 2022
Merged

speex: patch zero division vector in wave header parser#158978
risicle merged 1 commit intoNixOS:stagingfrom
mweinelt:speex

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 10, 2022

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-23903

Fixes: CVE-2020-23903

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-21.11 labels Feb 10, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 10, 2022
@mweinelt mweinelt changed the base branch from master to staging February 10, 2022 15:18
risicle
risicle approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built on nixos x86_64.

@risicle risicle merged commit 4614c36 into NixOS:staging Feb 15, 2022
@github-actions github-actions bot mentioned this pull request Feb 15, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022

Successfully created backport PR #160204 for staging-21.11.

@mweinelt mweinelt deleted the speex branch February 15, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mweinelt @risicle