Skip to content

python3Packages.rapidfuzz: 1.9.1 -> 2.0.2#158881

Closed
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:rapidfuzz-2.0.0
Closed

python3Packages.rapidfuzz: 1.9.1 -> 2.0.2#158881
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:rapidfuzz-2.0.0

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 10, 2022

Motivation for this change

https://github.com/maxbachmann/RapidFuzz/releases/tag/v2.0.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 10, 2022
@dotlambda
Copy link
Member Author

dotlambda commented Feb 10, 2022

Does someone know what I'm doing wrong?

CMake Error at /nix/store/irw4fr32wv87sq0d81ljxz9al30b7shq-python3.9-scikit-build-0.12.0/lib/python3.9/site-packages/skbuild/resources/cmake/targetLinkLibrariesWithDynamicLookup.cmake:579 (target_link_libraries):
  The keyword signature for target_link_libraries has already been used with
  the target "cpp_utils".  All uses of target_link_libraries with a target
  must be either all-keyword or all-plain.

  The uses of the keyword signature are here:

   * src/cython/CMakeLists.txt:8 (target_link_libraries)

Call Stack (most recent call first):
  /nix/store/irw4fr32wv87sq0d81ljxz9al30b7shq-python3.9-scikit-build-0.12.0/lib/python3.9/site-packages/skbuild/resources/cmake/FindPythonExtensions.cmake:427 (target_link_libraries_with_dynamic_lookup)
  src/cython/CMakeLists.txt:9 (python_extension_module)

dotlambda
dotlambda commented Feb 10, 2022
View reviewed changes
pkgs/development/python-modules/rapidfuzz/default.nix Outdated
Copy link
Member Author

@dotlambda dotlambda Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should scikit-build install these files to $out/share/cmake?

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 10, 2022
@dotlambda dotlambda changed the title python3Packages.rapidfuzz: 1.9.1 -> 2.0.0 python3Packages.rapidfuzz: 1.9.1 -> 2.0.2 Feb 16, 2022
@yuuyins
Copy link
Contributor

yuuyins commented Apr 14, 2022

@ofborg build test python3Packages.rapidfuzz

@yuuyins yuuyins mentioned this pull request Apr 14, 2022
Closed
13 tasks
@dotlambda
Copy link
Member Author

dotlambda commented Apr 14, 2022 •
edited
Loading

The error seems to be gone with the version of scikit-build on python-updates (#166489). However, scikit-build's test are broken on that branch. Help with fixing them is appreciated.

@dotlambda dotlambda closed this Apr 14, 2022
@dotlambda
Copy link
Member Author

dotlambda commented Apr 14, 2022

superseded by #168580

@dotlambda dotlambda deleted the rapidfuzz-2.0.0 branch January 17, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda @yuuyins