Skip to content

[haskell-updates] haskell-language-server: 1.5 -> 1.6#158192

Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
maralorn:hls-1.6
Feb 5, 2022
Merged

[haskell-updates] haskell-language-server: 1.5 -> 1.6#158192
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
maralorn:hls-1.6

Conversation

@maralorn
Copy link
Member

@maralorn maralorn commented Feb 5, 2022

Motivation for this change
  • Fix build for 1.6
  • Fix build on ghc 9.2
  • Enable all supported plugins on 9.0 and 9.2
  • Refactor overrides in configuration-nix because every hls-*-plugin test needs the same override.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@maralorn maralorn changed the title [haskell-updates] haskell-language-server 1.6 [haskell-updates] haskell-language-server: 1.5 -> 1.6 Feb 5, 2022
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 5, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 5, 2022
sternenseemann
sternenseemann approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything wrong with this. If you're happy that everything builds, feel free to merge.

@maralorn maralorn merged commit 48e61ed into NixOS:haskell-updates Feb 5, 2022
@maralorn maralorn deleted the hls-1.6 branch February 5, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maralorn @sternenseemann