Skip to content

readline: 8.1p0 -> 8.1p2, bash: 5.1p12 -> 5.1p16#157688

Merged
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:bash-readline
Feb 15, 2022
Merged

readline: 8.1p0 -> 8.1p2, bash: 5.1p12 -> 5.1p16#157688
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:bash-readline

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Feb 1, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
readline: add symlink to update-patch-set script
652deba 
to make it easier to update the patch sets and put the file in the right place
@SuperSandro2000
readline: 8.1p0 -> 8.1p2
8fc9333
@SuperSandro2000
bash: 5.1p12 -> 5.1p16
830435c
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 1, 2022
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Feb 1, 2022

@jonringer could you please take a look or build some things? my network is to slow for that.

@dtzWill dtzWill mentioned this pull request Feb 1, 2022
Closed
13 tasks
ju1m
ju1m approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ju1m ju1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not get to test it as it requires mass recompile.

trofi
trofi approved these changes Feb 13, 2022
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on x86_64-linux. Tested by building most of desktop's NixOS.

@SuperSandro2000 SuperSandro2000 merged commit ed96cc2 into NixOS:staging Feb 15, 2022
@SuperSandro2000 SuperSandro2000 deleted the bash-readline branch February 15, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@lsix lsix Awaiting requested review from lsix

2 more reviewers

@trofi trofi trofi approved these changes

@ju1m ju1m ju1m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @trofi @ju1m