Skip to content

Staging next gnome python#157516

Merged
jonringer merged 6 commits intoNixOS:staging-nextfrom
SuperSandro2000:staging-next-gnome-python
Jan 31, 2022
Merged

Staging next gnome python#157516
jonringer merged 6 commits intoNixOS:staging-nextfrom
SuperSandro2000:staging-next-gnome-python

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 31, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 31, 2022
Merged
13 tasks
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 31, 2022
@jtojnar
Copy link
Member

jtojnar commented Jan 31, 2022

Are import checks needed when there are tests? Those should already check that libraries can be imported.

jtojnar
jtojnar reviewed Jan 31, 2022
View reviewed changes
pkgs/development/python-modules/statmake/default.nix Outdated
Copy link
Member

@jtojnar jtojnar Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move postPatch up? It is lower level action executed with other phases so so far we have been always moving it down (see also https://discourse.nixos.org/t/document-attribute-ordering-in-package-expressions/4887).

Copy link
Member Author

@SuperSandro2000 SuperSandro2000 Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that post for the first time. So far everything I have seen is ordered in the order how it is run, not some higher, middle lower level ordering which is very abstract. I can drop this again and we move this discussion to another time.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 31, 2022

Are import checks needed when there are tests? Those should already check that libraries can be imported.

Yeah, we added them for simplicity and to check if checkInputs shadows some imports.

@SuperSandro2000 SuperSandro2000 force-pushed the staging-next-gnome-python branch from 6858c9f to a41f21d Compare January 31, 2022 13:30
@ofborg ofborg bot requested review from amaxine, dasj19, hedning and jtojnar January 31, 2022 13:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 31, 2022
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 31, 2022

@jtojnar I just saw your comment in the other thread and I am going to plug you in. I hope that is fine for you. I also found a bug in cffsubr which breaks the build which I am also to fix.

@SuperSandro2000 SuperSandro2000 force-pushed the staging-next-gnome-python branch from a41f21d to bbdfb4d Compare January 31, 2022 13:46
@SuperSandro2000 SuperSandro2000 force-pushed the staging-next-gnome-python branch from bbdfb4d to 1911f01 Compare January 31, 2022 13:47
jonringer
jonringer approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/157516

2 packages failed to build:
python310Packages.statmake python310Packages.ufo2ft

6 packages built:
python310Packages.cffsubr python310Packages.ufoLib2 python39Packages.cffsubr python39Packages.statmake python39Packages.ufo2ft python39Packages.ufoLib2

@SuperSandro2000 SuperSandro2000 deleted the staging-next-gnome-python branch January 31, 2022 15:56
@jtojnar
Copy link
Member

jtojnar commented Jan 31, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

@amaxine amaxine Awaiting requested review from amaxine

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @jtojnar @jonringer