Conversation
|
@GrahamcOfBorg test gnome gnome-xorg |
Remove nvidiaWayland NixOS option since it was severely out of date. https://ftp.gnome.org/pub/GNOME/sources/gdm/41/gdm-41.3.news
|
Most of the rebuild are actually just python packages via |
This comment has been minimized.
This comment has been minimized.
|
@ofborg build python3Packages.afdko |
There was a problem hiding this comment.
As it is now this PR fails to build:
applying patch /nix/store/d9iqkfpahq8hci53n1hsr09hq0qwnq41-fix-paths.patch
patching file gnome-session/gnome-session.in
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file gnome-session/gnome-session.in.rej
patching file gnome-session/main.c
error: builder for '/nix/store/xqrwrf8q36qr9jq30d4qysbw2l7l1534-gnome-session-41.3.drv' failed with exit code 1
I tested on x86_64 linux
https://ftp.gnome.org/pub/GNOME/sources/gnome-session/40/gnome-session-40.8.news https://ftp.gnome.org/pub/GNOME/sources/gnome-session/41/gnome-session-41.3.news - Patch no longer relies on grep (https://gitlab.gnome.org/GNOME/gnome-session/commit/db1a97c2ffa091a37087cad15c759554e6fbb4ad). - Also format the expression.
|
Thanks, seems to work in VM now. |
dasj19
left a comment
There was a problem hiding this comment.
Yes, now it builds.
And the changes look good.
|
Most python packages are missing import checks and they all have no maintainers. All packages need to have a maintainer. Going to add the gnome team to everything. Alternatively you can also add yourself or we create a fonttools maintainer team. |
|
Yeah, sorry about that. I used some other Python package as a template and forgot to check. I guess I will add myself since the packages do not really have much to do with GNOME other than to build Cantarell fonts. Unless @sternenseemann thinks creating a fonttools team would make sense. |
|
Either would be fine by me, it'd be great if we could manage the concern somehow. |
Motivation for this change
Fixes: #156025
Fixes: #156026
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes