Skip to content

Staging next 2022-01-29#157215

Merged
vcunat merged 66 commits intomasterfrom
staging-next
Feb 2, 2022
Merged

Staging next 2022-01-29#157215
vcunat merged 66 commits intomasterfrom
staging-next

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jan 29, 2022

This iteration is a bit special. As there's a screen-locking mass rebuild regression (#157112), I picked fix for that and security fixes from staging except cases that would have lots of darwin rebuilds (which is more loaded now; expat + rust). The intention is that this way we might be able to merge significantly quicker than usually while still getting the most urgent changes. (EDIT: that includes avoiding more risky changes.)


workflow docs: https://nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
constitutents: https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
jobset: https://hydra.nixos.org/jobset/nixpkgs/staging-next

Previous staging-next: #154708

github-actions bot and others added 21 commits January 26, 2022 00:01
- recent versions only accept libidn2 (not libidn)
- it's for free, as it's a runtime dependency of glibc anyway
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 29, 2022
@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. label Jan 29, 2022
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 31, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 31, 2022
@fabianhjr
Copy link
Member

due to gdm.nvidiaWayland removal on this PR a usage removal is required:

diff --git a/nixos/modules/hardware/video/nvidia.nix b/nixos/modules/hardware/video/nvidia.nix
index ff4225dc29a..7387f810f01 100644
--- a/nixos/modules/hardware/video/nvidia.nix
+++ b/nixos/modules/hardware/video/nvidia.nix
@@ -179,7 +179,7 @@ in
   in mkIf enabled {
     assertions = [
       {
-        assertion = with config.services.xserver.displayManager; (gdm.enable && gdm.nvidiaWayland) -> cfg.modesetting.enable;
+        assertion = with config.services.xserver.displayManager; gdm.enable -> cfg.modesetting.enable;
         message = "You cannot use wayland with GDM without modesetting enabled for NVIDIA drivers, set `hardware.nvidia.modesetting.enable = true`";
       }

@bachp
Copy link
Member

bachp commented Feb 1, 2022

Should we also pick #157709 ? It contains 3 important CVE fixes. One of them has a base score of 9.9 and allows remote code execution as root.

Already on master via #157729

github-actions bot and others added 2 commits February 1, 2022 18:01
GDM enables Wayland on supported platforms automatically (see ${gnome.gdm}/lib/udev/rules.d/61-gdm.rules), so we removed the `gdm.nvidiaWayland` option.

You will still need `hardware.nvidia.modesetting.enable = true;` with `nvidia` driver, though.
@jtojnar
Copy link
Member

jtojnar commented Feb 1, 2022

Thanks removed the assertion altogether in e00317b.

@fabianhjr
Copy link
Member

Built and booted into staging-next. Thanks for the patch @jtojnar! UwU

@vcunat vcunat merged commit f85152d into master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants