Improvements to qgis and grass packaging, introduce qgis-ltr derivation (revised)#156747
Merged
jonringer merged 8 commits intoNixOS:masterfrom Jan 26, 2022
Merged
Improvements to qgis and grass packaging, introduce qgis-ltr derivation (revised)#156747jonringer merged 8 commits intoNixOS:masterfrom
jonringer merged 8 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
jonringer
reviewed
Jan 25, 2022
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Thanks for pushing this forwards @willcohen |
jonringer
reviewed
Jan 25, 2022
Contributor
|
other than that, diff LGTM the git history could use some squashing of fixup commits. I think there's around 8 logical actions done, there should be a commit for each: |
Contributor
Author
|
Got it. Will squash and cleanup. |
This is used for processing lidar point clouds.
ofborg
bot
added
the
8.has: clean-up
Grass is a runtime dependency which qgis attempts to find on the path. 3D is on by default with normal distributions so we should also enable it.
Add qtlocation to pyqt, and ensure that it is included with both qgis derivations.
Contributor
Author
|
Squashed and reordered. Re-running |
Contributor
Author
|
Result of 3 packages built:
|
Contributor
Author
|
ofborg seems stuck on darwin but we know it'll fail there, so this looks ready to go from my perspective, unless there's any other changes! |
13 tasks
jonringer
approved these changes
Jan 26, 2022
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
After 6 hours, this finally finished:
https://github.com/NixOS/nixpkgs/pull/156747
3 packages built:
grass qgis qgis-ltr
Contributor
Author
|
Many, many thanks @jonringer! |
13 tasks
13 tasks
This was referenced Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Picking up on @mpickering's #150286
I've built it on an x86_linux machine but don't actually have a working X environment on it that I can access so I can only confirm that it builds rather than test functionality.
@sikmir @erictapen @lsix
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes