Skip to content

gixy: pin pyparsing at 2.4.7#156702

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:gixy
Jan 25, 2022
Merged

gixy: pin pyparsing at 2.4.7#156702
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:gixy

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 25, 2022 •
edited
Loading

Motivation for this change

c84b744#commitcomment-64574657
https://hydra.nixos.org/log/c20mxx2p928zjz4ycvl5sgsl7ln0rmyz-gixy-0.1.20.drv

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from vcunat January 25, 2022 13:20
vcunat referenced this pull request Jan 25, 2022
@mweinelt
python3Packages.pyparsing: 2.4.7 -> 3.0.6
c84b744
vcunat
vcunat approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK to me.

It fixes the test. As gixy appears to be leaf application (and rarely referenced), I don't expect risk of the older version clashing with somewhere else.

@mweinelt mweinelt marked this pull request as ready for review January 25, 2022 14:18
@mweinelt mweinelt merged commit 50d8173 into NixOS:staging Jan 25, 2022
@mweinelt mweinelt deleted the gixy branch January 25, 2022 14:40
@ofborg ofborg bot requested a review from WilliButz January 25, 2022 16:41
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mweinelt @vcunat