Skip to content

fix: autoconf-2.13#156656

Merged
c0bw3b merged 2 commits intoNixOS:stagingfrom
luochen1990:master
Feb 10, 2022
Merged

fix: autoconf-2.13#156656
c0bw3b merged 2 commits intoNixOS:stagingfrom
luochen1990:master

Conversation

@luochen1990
Copy link
Contributor

@luochen1990 luochen1990 commented Jan 25, 2022 •
edited
Loading

Motivation for this change

Find a typo.

Things done

Fixed the typo from nativebuildInputs into nativeBuildInputs, but it also works without nativeBuildInputs = [ xz ];, so we might delete this dependency as well.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 2, 2022
@siraben
Copy link
Member

siraben commented Feb 6, 2022

Result of nixpkgs-review pr 156656 run on aarch64-darwin 1

1 package built:
  • autoconf213

@siraben
Copy link
Member

siraben commented Feb 6, 2022

This should go into staging.

@luochen1990 luochen1990 marked this pull request as ready for review February 7, 2022 03:08
@luochen1990 luochen1990 changed the base branch from master to staging February 7, 2022 03:11
@c0bw3b
Copy link
Contributor

c0bw3b commented Feb 10, 2022

I will squash-merge this to make it one single commit with a commit message following nixpkgs manual.

@c0bw3b c0bw3b merged commit 584a8b3 into NixOS:staging Feb 10, 2022
@c0bw3b
Copy link
Contributor

c0bw3b commented Feb 10, 2022

Thanks for raising this @luochen1990

@siraben
Copy link
Member

siraben commented Feb 10, 2022

Can xz be removed as a dependency altogether?

@luochen1990
Copy link
Contributor Author

luochen1990 commented Feb 11, 2022

@siraben I tried to remove xz and it build successfully, but I'm not sure whether there is any different with the output.

@c0bw3b c0bw3b mentioned this pull request Feb 11, 2022
Merged
13 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Feb 11, 2022

I did the same test. xz is unused during the build and there is no reference to xz or lzma in all the binaries/scripts it produces.

I made a PR to remove it (linked above).

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luochen1990 @siraben @c0bw3b @Janik-Haag