Skip to content

git: 2.34.1 -> 2.35.0#156610

Merged
primeos merged 1 commit intoNixOS:stagingfrom
primeos:git
Jan 26, 2022
Merged

git: 2.34.1 -> 2.35.0#156610
primeos merged 1 commit intoNixOS:stagingfrom
primeos:git

Conversation

@primeos
Copy link
Member

@primeos primeos commented Jan 24, 2022 •
edited
Loading

Motivation for this change

Release notes: https://github.com/git/git/blob/v2.35.0/Documentation/RelNotes/2.35.0.txt

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Jan 24, 2022

@ofborg build gitMinimal git gitFull

@zowoq zowoq mentioned this pull request Jan 25, 2022
Closed
13 tasks
@zowoq
Copy link
Contributor

zowoq commented Jan 25, 2022

@ofborg eval

@ofborg ofborg bot requested review from globin and wmertens January 25, 2022 14:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 25, 2022
jonringer
jonringer approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

https://github.com/NixOS/nixpkgs/pull/156610

3 packages built:
git gitFull gitMinimal

@primeos primeos merged commit bf4e2bf into NixOS:staging Jan 26, 2022
@jonringer
Copy link
Contributor

jonringer commented Jan 26, 2022

oh yea, meant to merge. My bad

@primeos
Copy link
Member Author

primeos commented Jan 26, 2022

No problem :) Thanks for your review!

@primeos primeos mentioned this pull request Jan 29, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmertens wmertens Awaiting requested review from wmertens

@globin globin Awaiting requested review from globin

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@primeos @zowoq @jonringer