Improve check that evaluation does not depend on the Nixpkgs path#156587
Merged
edolstra merged 2 commits intoNixOS:masterfrom Jan 25, 2022
Merged
Improve check that evaluation does not depend on the Nixpkgs path#156587edolstra merged 2 commits intoNixOS:masterfrom
edolstra merged 2 commits intoNixOS:masterfrom
Conversation
Otherwise you end up with a derivation that refers to the original path (which is not in the Nix store and not accessible to builders). This caused the derivation paths for the docbookrx package (removed on master) to depend on the location of the nixpkgs source tree.
github-actions
bot
added
the
6.topic: ruby
edolstra
added
the
6.topic: release process
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
Merged
1 task
Contributor
|
Successfully created backport PR #156751 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While adding a evaluation regression test to Nix, I found that the
docbookrxpackage in revision b1f2623 depends on the location of Nixpkgs. The functionpathDerivationinpkgs/development/ruby-modules/bundled-common/functions.nixencodes the source path of the Gem (e.g./home/eelco/Dev/nixpkgs/pkgs/tools/typesetting/docbookrx) into the derivation, which is impure and doesn't work in a sandboxed environment. The fix is to ensure that the input is copied to the store. I also improved the test inpkgs/top-level/nixpkgs-basic-release-checks.nixto make sure that this is caught.Note that
docbookrxhas been removed in master, but we should ensure that this doesn't reoccur.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes