python3Packages.numpy: 1.21.5 -> 1.23.1#156578
python3Packages.numpy: 1.21.5 -> 1.23.1#156578mweinelt wants to merge 1 commit intoNixOS:stagingfrom
Conversation
|
The scikit-learn tests are now crashing for me. @ofborg build python3Packages.scikit-learn |
|
Probably best to keep for a new python-unstable iteration. |
|
Wanted ofBorg to check if the error is reproducible, happy to keep this a draft for now. |
|
hey is there any update on this? |
|
Doing another bump shortly |
|
@ofborg build python3Packages.scikit-learn |
|
|
It's looking like this is some sort of heap corruption. Which is painful to debug because it only throws errors when things are deallocated, long after the culprit has finished executing. |
|
|
The suggestion is that the fix for this should be numpy/numpy@258c3ab, but this is present in 1.22.2 already. Edit: of course I say a fix for "this", but that should be a fix for "an issue caused by that PR". Our issue could be a separate problem with that PR. |
|
Valgrind revealed more in the end: Full python-annotated stack trace for the first of these: https://gist.github.com/risicle/b52b924f4e7353f1b306645499cb2e60 Assembly listing of write: Could it be trying to write a 64bit value into a 32bit allocation? |
|
|
|
Turns out it's more like https://github.com/xianyi/OpenBLAS/blob/0b678b19dc03f2a999d6e038814c4c50b9640a4e/lapack-netlib/SRC/dlar1v.f#L405 but pretty close the first time. (backtrace with fortran debug info https://gist.github.com/risicle/c20d85a6922a9cbc92312aa1b0c1f65f) |
|
@ofborg build python3Packages.scikit-learn |
|
any reason for this being closed? like a new pr? |
Motivation for this change
numpy updates
https://github.com/numpy/numpy/releases/tag/v1.22.0
https://github.com/numpy/numpy/releases/tag/v1.22.1
https://github.com/numpy/numpy/releases/tag/v1.22.2
numpy/numpy#20886 to fix scipy/scipy#15414
scipy updates
https://scipy.github.io/devdocs/release.1.8.0.html
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes