irods: Don't use builtins.nixVersion#156527
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jan 24, 2022
Merged
Conversation
The value of builtins.nixVersion should never be used except to bail out if it's too old. It causes the evaluation result to depend on the version of Nix, so e.g. the binary cache doesn't work.
1 task
Contributor
|
Successfully created backport PR #156552 for |
edolstra
added a commit
to edolstra/nix
that referenced
this pull request
Jan 24, 2022
This prevents issues like NixOS/nixpkgs#156527. Eventually we should do this in impure mode as well. Issue NixOS#5970.
This was referenced Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of
builtins.nixVersionshould never be used except to bail out if it's too old. It causes the evaluation result to depend on the version of Nix, so e.g. the binary cache doesn't work.Found when trying to use Nixpkgs as a regression test suite for Nix. This is the only package whose
nix-envoutput differs between Nix versions.