qt515: Update KDE Qt 5.15 patches#156376
Merged
ttuegel merged 5 commits intoNixOS:stagingfrom Feb 11, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: qt/kde
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
Author
Some odd failures here which seem not to happen if I build without nixpkgs-review, I tried with I don't know how to refer to the version change here in a changelog or whatever since there isn't a version number to go along with these. |
Member
Author
|
Have been running these with plasma 5.23 and not noticed any problems. |
Member
Author
|
Changed this to target staging due to big rebuild, hope that was correct. |
Member
Author
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
13 tasks
Member
Author
|
One more fix landed in qtwayland for a bug which causes the plasma panel to stop updating. https://bugs.kde.org/show_bug.cgi?id=449163 |
Member
|
Thanks! I'm not very well qualified to review this. Maybe one of the maintainers could have a look? I have requested reviews from the qt and plasma maintainers. |
Member
|
I've not reviewed the changes, but I can say that they work! I've tested this on my Ryzen laptop, and my Nvidia-powered Desktop machine. Without these patches, Plasma would only start... less than 10% of the time with my 4K TV and ultrawide-1440p monitor attached. With these patches, Plasma boots up nice and smoothly. (Still some artifacting going on that I think is just nvidia/gbm stuffs.) |
ttuegel
approved these changes
Feb 11, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm most interested in this change https://invent.kde.org/qt/qt/qtwayland/-/commit/4644d51f4b52e83fc1b4d02b380d80d9d57e76fa which makes performance on nvidia wayland usable, but there are many other changes.
We're expected to keep these up to date as we update plasma5, but that was updated a few weeks ago and our patches are from October.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes