Skip to content

impressive: remove#156327

Merged
Ma27 merged 2 commits intoNixOS:masterfrom
lheckemann:remove-impressive
Jan 28, 2022
Merged

impressive: remove#156327
Ma27 merged 2 commits intoNixOS:masterfrom
lheckemann:remove-impressive

Conversation

@lheckemann
Copy link
Member

Motivation for this change

Upstream seems fairly dead, and I don't want to maintain the package anymore.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 23, 2022
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it'd make sense to add a impressive = throw "Removed, unmaintained"; or sth. similar to aliases.nix, other than that LGTM 👍

- The latest stable release 0.11.0 does not support python 2.x and
  relies on an outdated Pillow which has several vulnerabilities
- The latest beta release 0.13.0-beta2 supports python 3.x and is
  packageable but segfaults
- I am the only maintainer and not willing to put further effort into it.
@Ma27 Ma27 merged commit 2d7e8a0 into NixOS:master Jan 28, 2022
@lheckemann lheckemann deleted the remove-impressive branch February 1, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants