Skip to content

[staging] spice: properly test for existance of python modules#156305

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:spice
Jan 23, 2022
Merged

[staging] spice: properly test for existance of python modules#156305
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:spice

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 23, 2022

Motivation for this change
spice-common| Program python3 found: YES (/nix/store/hxgsg4nn1w47lrbzb20l0b2kzhgi6fmy-python3-3.9.10/bin/python3.9)
spice-common| Message: Checking for python module six
spice-common| Message: Checking for python module pyparsing

subprojects/spice-common/meson.build:137:8: ERROR: Problem encountered: Python module pyparsing not found

A full log can be found at /build/spice-0.15.0/build/meson-logs/meson-log.txt

❯ python3 -m pyparsing
/nix/store/civfhqs0ldmyplxhwhm0rja4is242q0p-python3-3.9.10-env/bin/python3.9: No module named pyparsing.__main__; 'pyparsing' is a package and cannot be directly executed
❯ python3 -c 'import pyparsing'; echo $?
0
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title spice: properly test for existance of python modules [staging] spice: properly test for existance of python modules Jan 23, 2022
@mweinelt mweinelt mentioned this pull request Jan 23, 2022
Merged
13 tasks
@ofborg ofborg bot requested a review from bluescreen303 January 23, 2022 12:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 23, 2022
trofi
trofi approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes spice build for me on x86_64-linux. Thank you!

@mweinelt mweinelt merged commit 430334a into NixOS:staging Jan 23, 2022
@mweinelt mweinelt deleted the spice branch January 23, 2022 12:41
@jktjkt jktjkt mentioned this pull request Feb 11, 2022
Closed
@andersk
Copy link
Contributor

andersk commented Feb 11, 2022 •
edited
Loading

This also needs to be applied to spice-gtk.

Or we can bump spice-gtk with the upstream fix.

@kuwii kuwii mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

1 more reviewer

@trofi trofi trofi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @andersk @trofi