Skip to content

gnome.gdm: 41.0 -> 41.3#156025

Closed
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/gnome.gdm
Closed

gnome.gdm: 41.0 -> 41.3#156025
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/gnome.gdm

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 21, 2022

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for gnome.gdm is: "A program that manages graphical display servers and handles graphical user logins"

meta.homepage for gnome.gdm is: "https://wiki.gnome.org/Projects/GDM"

meta.changelog for gnome.gdm is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • Warning: no invocation of /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3/bin/gdmflexiserver had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3/bin/gdm had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3/bin/gdm-screenshot had a zero exit code or showed the expected version
  • 0 of 3 passed binary check by having a zero exit code.
  • 0 of 3 passed binary check by having the new version present in output.
  • found 41.3 with grep in /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3
  • found 41.3 in filename of file in /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3
Rebuild report (if merged into master) (click to expand) 
21 total rebuild path(s)

19 package rebuild(s)

19 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
adapta-gtk-theme
chrome-gnome-shell
gnome.gdm
gnome.gnome-applets
gnome.gnome-flashback
gnome.gnome-initial-setup
gnome.gnome-panel
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-terminal
gnome.gnome-tweaks
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
pantheon.elementary-session-settings
phosh
vimix-gtk-themes
whitesur-gtk-theme
xmonad_log_applet
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gnome.gdm https://github.com/r-ryantm/nixpkgs/archive/5782f002b198089fa18aa5f02f8df5ea29ffdfbe.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3
ls -la /nix/store/nizxcws49zkv7cvn20ilc6nlrmfdh98n-gdm-41.3/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:
  • xmonad_log_applet
18 packages built:
  • adapta-gtk-theme
  • chrome-gnome-shell
  • gnome.gdm
  • gnome.gnome-applets
  • gnome.gnome-flashback
  • gnome.gnome-initial-setup
  • gnome.gnome-panel
  • gnome.gnome-session
  • gnome.gnome-shell
  • gnome.gnome-terminal
  • gnome.gnome-tweaks
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • pantheon.elementary-session-settings
  • phosh
  • vimix-gtk-themes
  • whitesur-gtk-theme
Maintainer pings

cc @hedning @jtojnar @dasj19 @maxeaubrey for testing.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 21, 2022
@ofborg ofborg bot requested review from amaxine and dasj19 January 21, 2022 08:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 21, 2022
dasj19
dasj19 reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog contains crash- and bug-fixes: https://mirrors.dotsrc.org/gnome/sources/gdm/41/gdm-41.3.news

dasj19
dasj19 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my system

@jtojnar
Copy link
Member

jtojnar commented Jan 21, 2022

https://gitlab.gnome.org/GNOME/gdm/-/compare/41.0...41.3

We might need to duplicate the udev changes in our module:

nixpkgs/nixos/modules/services/x11/display-managers/gdm.nix

Lines 233 to 244 in 23e67cc

# We duplicate upstream's udev rules manually to make wayland with nvidia configurable
services.udev.extraRules = ''
# disable Wayland on Cirrus chipsets
ATTR{vendor}=="0x1013", ATTR{device}=="0x00b8", ATTR{subsystem_vendor}=="0x1af4", ATTR{subsystem_device}=="0x1100", RUN+="${gdm}/libexec/gdm-runtime-config set daemon WaylandEnable false"
# disable Wayland on Hi1710 chipsets
ATTR{vendor}=="0x19e5", ATTR{device}=="0x1711", RUN+="${gdm}/libexec/gdm-runtime-config set daemon WaylandEnable false"
${optionalString (!cfg.gdm.nvidiaWayland) ''
DRIVER=="nvidia", RUN+="${gdm}/libexec/gdm-runtime-config set daemon WaylandEnable false"
''}
# disable Wayland when modesetting is disabled
IMPORT{cmdline}="nomodeset", RUN+="${gdm}/libexec/gdm-runtime-config set daemon WaylandEnable false"
'';

Hate stuff like this.

@jtojnar jtojnar mentioned this pull request Jan 30, 2022
Merged
13 tasks
@bobby285271
Copy link
Member

bobby285271 commented Feb 3, 2022

Closing as 1a11eb1 is in master.

@bobby285271 bobby285271 closed this Feb 3, 2022
@r-ryantm r-ryantm deleted the auto-update/gnome.gdm branch February 4, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@amaxine amaxine Awaiting requested review from amaxine

1 more reviewer

@dasj19 dasj19 dasj19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r-ryantm @jtojnar @bobby285271 @dasj19