Skip to content

haskellPackages.hs-speedscope: unbreak#155520

Merged
expipiplus1 merged 1 commit intoNixOS:haskell-updatesfrom
ulysses4ever:hs-speedscope-jailbreak
Jan 19, 2022
Merged

haskellPackages.hs-speedscope: unbreak#155520
expipiplus1 merged 1 commit intoNixOS:haskell-updatesfrom
ulysses4ever:hs-speedscope-jailbreak

Conversation

@ulysses4ever
Copy link
Contributor

@ulysses4ever ulysses4ever commented Jan 18, 2022

Motivation for this change

hs-speedscope is currently broken because of a too tight upper bound on ghc-events (< 0.16) but builds okay with the newer version of ghc-events currently present in nixpkgs (0.17.0.1). In fact, current upstream of hs-speedscope has already bumped the bound, but this has not been released on Hackage (and Stackage). I opened an issue about releasing.

nixpkgs-review runs out of disk space on my machine :-(

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jan 18, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 18, 2022
@expipiplus1
Copy link
Contributor

Thanks!

@expipiplus1 expipiplus1 merged commit ce12b79 into NixOS:haskell-updates Jan 19, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants