Skip to content

headphones: 0.5.20 -> 0.6.0-alpha.1#155466

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
rembo10:headphones-python3-update
Jan 20, 2022
Merged

headphones: 0.5.20 -> 0.6.0-alpha.1#155466
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
rembo10:headphones-python3-update

Conversation

@rembo10
Copy link
Contributor

@rembo10 rembo10 commented Jan 18, 2022

Motivation for this change

Headphones was removed from nixpkgs because it was not compatible with python3. This version works on python3

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 18, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the build on x86_64-darwin successfully.

$ nix-build -A headphones
these 2 derivations will be built:
  /nix/store/y8w8yvjxfsjrjz38hc7m7c5kapj7ha4z-source.drv
  /nix/store/x0bslibsa9540d4rjv42zvs6s2nga5fg-headphones-0.6.0-alpha.1.drv
building '/nix/store/y8w8yvjxfsjrjz38hc7m7c5kapj7ha4z-source.drv'...

trying https://github.com/rembo10/headphones/archive/v0.6.0-alpha.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   134  100   134    0     0    558      0 --:--:-- --:--:-- --:--:--   560
100 3684k    0 3684k    0     0  3726k      0 --:--:-- --:--:-- --:--:-- 6293k
unpacking source archive /private/tmp/nix-build-source.drv-0/v0.6.0-alpha.1.tar.gz
building '/nix/store/x0bslibsa9540d4rjv42zvs6s2nga5fg-headphones-0.6.0-alpha.1.drv'...
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
unpacking sources
unpacking source archive /nix/store/82v6spcdizlkx9gz94k1cgwvgrgynrin-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/setup.cfg
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/j5bv1crdxnsvdj1w70445lfg63amq0gy-cctools-binutils-darwin-949.0.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1/bin 
patching script interpreter paths in /nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1
/nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1/opt/headphones/lib/twitter/api.py: interpreter directive changed from "#!/usr/bin/env python" to "/nix/store/fkygdjhm2raz32xrzwnq8b89hkkdc9vv-python3-3.9.9/bin/python"
/nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1/opt/headphones/lib/pynma/pynma.py: interpreter directive changed from "#!/usr/bin/python" to "/nix/store/fkygdjhm2raz32xrzwnq8b89hkkdc9vv-python3-3.9.9/bin/python"
/nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1/opt/headphones/Headphones.py: interpreter directive changed from "#!/usr/bin/env python" to "/nix/store/fkygdjhm2raz32xrzwnq8b89hkkdc9vv-python3-3.9.9/bin/python"
Rewriting #! /nix/store/b0q4wjdw6xwhfsqy8ab106cmhn5xrr8p-bash-5.1-p12/bin/bash -e to #!/nix/store/fkygdjhm2raz32xrzwnq8b89hkkdc9vv-python3-3.9.9
Executing pythonRemoveTestsDir
Finished executing pythonRemoveTestsDir
pythonCatchConflictsPhase
pythonRemoveBinBytecodePhase
pythonImportsCheckPhase
Executing pythonImportsCheckPhase
/nix/store/dic3nr75fiy9rzb1yfwbk73s8jvr86vw-headphones-0.6.0-alpha.1

@SuperSandro2000 SuperSandro2000 merged commit e8a380a into NixOS:master Jan 20, 2022
@rembo10
Copy link
Contributor Author

rembo10 commented Jan 20, 2022

thanks @NotGordias @SuperSandro2000 !

@rembo10 rembo10 deleted the headphones-python3-update branch January 20, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants