Skip to content

gpgme: add patch for Python 3.10 support#155384

Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
fabaff:fix-gpgme
Feb 19, 2022
Merged

gpgme: add patch for Python 3.10 support#155384
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
fabaff:fix-gpgme

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Jan 17, 2022

Motivation for this change

Fix build (https://hydra.nixos.org/build/164507537)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 17, 2022
@ofborg ofborg bot requested a review from nlewo January 17, 2022 15:40
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 17, 2022
@fabaff
Copy link
Member Author

fabaff commented Jan 17, 2022

This will trigger a little over 1k builds.

@fabaff
Copy link
Member Author

fabaff commented Jan 17, 2022

@ofborg build gpgme

@github-actions github-actions bot added 6.topic: bsd Running or building packages on BSD 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: printing Drivers, CUPS & Co. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: changelog This PR adds or changes release notes labels Jan 17, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 17, 2022
This was referenced Jan 21, 2022
Merged
Merged
@risicle risicle mentioned this pull request Feb 13, 2022
Closed
13 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 18, 2022

Going to merge this right after #160794 to get openstack for 3.10 in a better shape.

@SuperSandro2000 SuperSandro2000 self-assigned this Feb 18, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 19, 2022 •
edited
Loading

@ofborg eval
@ofborg build gpgme python39Packages.gpgme python310Packages.gpgme

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 19, 2022
SuperSandro2000
SuperSandro2000 reviewed Feb 19, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Feb 19, 2022
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 19, 2022 •
edited
Loading

I manually build this PR before and something else in the dependency chain of rust is broken....

Edit: yeah, broken by #160826. Just going a head and merging this since I am sure it works.

@SuperSandro2000 SuperSandro2000 merged commit 56d30ff into NixOS:staging Feb 19, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 19, 2022 •
edited
Loading

It worked before but now it fails with because python3.10 -c "import distutils" outputs <string>:1: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives.

Fixing in another PR right now.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Feb 19, 2022
Merged
13 tasks
vcunat added a commit that referenced this pull request Mar 15, 2022
@vcunat
gpgme: fix the qt5 bindings
415d23f 
Commit 1340607 (PR #155384) broke list-nesting of the passed qtbase.

Surprisingly to me, that prevented it from appearing in PKG_CONFIG_PATH
and thus from building the Qt bindings.  Subsequently those were then
missing in libsForQt5.libkleo and maybe other places.
@fabaff fabaff deleted the fix-gpgme branch December 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@nlewo nlewo Awaiting requested review from nlewo

Assignees

@SuperSandro2000 SuperSandro2000

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @SuperSandro2000 @jtojnar