Skip to content

hlint: add manpage#155382

Merged
teto merged 2 commits intoNixOS:haskell-updatesfrom
teto:hlint-manpage
Jan 18, 2022
Merged

hlint: add manpage#155382
teto merged 2 commits intoNixOS:haskell-updatesfrom
teto:hlint-manpage

Conversation

@teto
Copy link
Member

@teto teto commented Jan 17, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jan 17, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 17, 2022
sternenseemann
sternenseemann requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this override into configuration-nix.nix as well, since this is not a temporary workaround type override.

@teto
Copy link
Member Author

teto commented Jan 17, 2022

thanks for the onpoint review. There is 0 line left from my initial PR but it is much better now ;)

@sternenseemann sternenseemann changed the base branch from master to haskell-updates January 18, 2022 10:31
sternenseemann
sternenseemann requested changes Jan 18, 2022
View reviewed changes
@teto teto merged commit 89b3b42 into NixOS:haskell-updates Jan 18, 2022
@teto teto deleted the hlint-manpage branch January 18, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann requested changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teto @sternenseemann