Skip to content

maintainers/scripts/update.nix: use ascii arrow#155309

Closed
06kellyjac wants to merge 1 commit intoNixOS:masterfrom
06kellyjac:maintainer-ascii
Closed

maintainers/scripts/update.nix: use ascii arrow#155309
06kellyjac wants to merge 1 commit intoNixOS:masterfrom
06kellyjac:maintainer-ascii

Conversation

@06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Jan 17, 2022

Motivation for this change

Move from a unicode arrow to an ascii arrow. The ascii arrow seems to be prefered in CONTRIBUTING now and this script is the source of a lot of these unicode arrows.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac requested a review from jtojnar as a code owner January 17, 2022 09:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 17, 2022
@jtojnar
Copy link
Member

jtojnar commented Jan 17, 2022

Maybe we should update CONTRIBUTING instead 😉

The ASCII “arrow“ is extremely ugly since the dash does not line up with the tip of the greater than sign in most fonts.

@06kellyjac
Copy link
Member Author

06kellyjac commented Jan 17, 2022

I'd much prefer an unaligned arrow I can just type than a unicode character I need to go look up

@jtojnar
Copy link
Member

jtojnar commented Jan 17, 2022 •
edited
Loading

With compose key, it is as simple as pressing Compose followed by those two characters. But I would just suggest updating contributing to explicitly mention the Unicode alternative, rather than forbidding the ASCII variant.

One issue with switching update.nix to use ASCII is that update.nix is also used by repos which do not allow the ASCII variant, whereas Nixpkgs seems to have been tolerating the Unicode variant so far.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 2, 2022
@Artturin Artturin closed this Jan 27, 2023
@06kellyjac 06kellyjac deleted the maintainer-ascii branch February 2, 2023 19:33
@Artturin Artturin mentioned this pull request Apr 5, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@06kellyjac @jtojnar @Artturin