gnome2.vte: drop with all reverse dependencies#155048
gnome2.vte: drop with all reverse dependencies#155048AndersonTorres merged 5 commits intoNixOS:masterfrom
Conversation
mweinelt
force-pushed
the
python2-must-die
branch
from
47e455c to
1e7ada9
Compare
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 0
mweinelt
changed the title
FRidh
left a comment
FRidh
left a comment
There was a problem hiding this comment.
Looks good to me, but let's keep it open for some days.
|
I second this. The only nit is that the commit dropping |
mweinelt
force-pushed
the
python2-must-die
branch
from
1e7ada9 to
96a8d48
Compare
|
Goodbye, lilyterm! P.S.: nice branch name! |
|
I'm afraid it only rhymes in german. |
dasj19
left a comment
dasj19
left a comment
There was a problem hiding this comment.
Looks good. Good you replaced the packages with explanatory aliases.
mweinelt
force-pushed
the
python2-must-die
branch
from
96a8d48 to
27fa34f
Compare
|
Fixed a typo in the throw for lilyterm. |
|
evilvte: Indeed, you could just use the same message on gnome2.vte and evilvte: |
Depends on a VTE version that is about to be dropped for depening on pythn2Packages.pygtk. Also unmaintained and with known security issues.
Drop both variants of lilyterm for requiring an outdated vte version that is about to be dropped.
Uses much less dependencies than we were giving it these days.
Depends on pygtk, which is python2 only and thus due for removal.
mweinelt
force-pushed
the
python2-must-die
branch
from
27fa34f to
6de75c7
Compare
|
Fixed two typos on the evilvte throw, but otherwise I consider it to be fine. Not sure where I would add a throw for gnome2.vte, since it has no aliases file and I'm not sure adding aliases to gnome2s default.nix is allowed. |
|
A throw on |
| curl | ||
| cdparanoia | ||
| libid3tag | ||
| ncurses |
There was a problem hiding this comment.
Does it run without ncurses? That's interesting.
Usually ncurses is at least optional dependency, but you are removing it completely...
There was a problem hiding this comment.
Grip is a gtk2 application, I downloaded the tarball and worked through the INSTALL, which reads like so:
Requirements
============
To use Grip, you must have a few dependencies.
If you obtained Grip from an RPM or DEB file, then they are already installed.
The dependencies are:
A CD/DVD player (surprise, surprise)
Some GTK2 libraries.
On a Redhat/Fedora/Mageia/OpenMandriva or other RPM based distributions,
you need these packages installed:
gtk2-devel
cdda-devel
id3-devel
On Debian derivatives you need these packages, as listed in the Debian control file (as maintained by Josef Grosch):
libgtk2.0-dev
libcurl4-openssl-dev
libid3-3.8.3-dev
Installation
============
If you have the source distribution, you need to compile it.
To compile and install Grip, simply go through one of the following two steps after extracting the tarball:
Alternative 1, meson:
* mkdir build
* cd build
* meson ../
* ninja
become root if you are installing in a non-user directory, then run
* ninja install
Alternative 2, GNU autotools (The old and trusted way):
* './configure'
* 'make'
become root if you are installing in a non-user directory, then run
* 'make install'
For information on options to the configure process, run:
./configure --help
Grip adds the following options that can be specified to configure:
--disable-shared-cdpar -- This will force Grip to link statically, rather
than dynamically with cdparanoia
--disable-cdpar -- This disable linking with cdparanoia entirely
--disable-shared-id3 -- This will force Grip to link statically, rather
than dynamically with id3lib
--enable-werror -- This will turn warnings into errors.
Use this option when creating and testing patches.
Note that if Gnome is installed in a non-standard place (such as /opt), you
may need to use the '--with-gnome' configure option for all libraries to be
found correctly.
Feel free to push that change. |
6 participants
Motivation for this change
Using pygtk, which is python2 only.
Hoping that evilvte is the only remaining consumer. (LOL, it is not.)
#148779
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes