Skip to content

cryptsetup: 2.4.2 -> 2.4.3#154911

Merged
grahamc merged 1 commit intoNixOS:masterfrom
mweinelt:cryptsetup
Jan 13, 2022
Merged

cryptsetup: 2.4.2 -> 2.4.3#154911
grahamc merged 1 commit intoNixOS:masterfrom
mweinelt:cryptsetup

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 13, 2022

Motivation for this change

https://www.openwall.com/lists/oss-security/2022/01/13/2
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.4.3-ReleaseNotes

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 13, 2022
@mweinelt mweinelt requested review from grahamc and risicle January 13, 2022 17:28
@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 13, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 13, 2022
grahamc
grahamc approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, direct to master is appropriate.

@mweinelt
Copy link
Member Author

mweinelt commented Jan 13, 2022 •
edited
Loading

Testing

  • nixosTests.systemd-cryptenroll
  • nixosTests.systemd and
  • nixosTests.installer

on x86_64-linux, all of which were mentioning cryptsetup.

@vcunat
Copy link
Member

vcunat commented Jan 13, 2022

So I expect we should cancel the rest of staging-next-21.11 builds for now? And resume after something similar gets added into the branch?

@mweinelt
Copy link
Member Author

mweinelt commented Jan 13, 2022

We have a jobset based on unstable-small going rn.

https://hydra.nixos.org/jobset/nixos/pr-154911-cryptsetup-unstable-small

@grahamc grahamc merged commit 5aaed40 into NixOS:master Jan 13, 2022
@mweinelt mweinelt mentioned this pull request Jan 13, 2022
Merged
13 tasks
@mweinelt mweinelt deleted the cryptsetup branch January 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle Awaiting requested review from risicle

1 more reviewer

@grahamc grahamc grahamc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @vcunat @grahamc