Skip to content

llvmPackages_13.clang: add nostdlibinc flag#153963

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
crabtw:clang13
Feb 14, 2022
Merged

llvmPackages_13.clang: add nostdlibinc flag#153963
Ericson2314 merged 1 commit intoNixOS:stagingfrom
crabtw:clang13

Conversation

@crabtw
Copy link
Contributor

@crabtw crabtw commented Jan 8, 2022

Motivation for this change

This patch adds nostdlibinc flag after parsing arguments
instead of sed substitution.

Fix #151879

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@crabtw crabtw requested a review from matthewbauer as a code owner January 8, 2022 08:15
@crabtw
Copy link
Contributor Author

crabtw commented Jan 8, 2022

cc @lovek323 @raskin @dtzWill @primeos

@ofborg ofborg bot requested review from 7c6f434c, dtzWill, lovek323 and primeos January 8, 2022 08:28
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 8, 2022
7c6f434c
7c6f434c approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. @matthewbauer ?

@7c6f434c
Copy link
Member

7c6f434c commented Feb 13, 2022

I think it is better to target staging here

@github-actions github-actions bot added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: vim Advanced text editor labels Feb 14, 2022
@crabtw
llvmPackages_13.clang: add nostdlibinc flag
2fe19fe 
This patch adds nostdlibinc flag after parsing arguments
instead of sed substitution.

Fix NixOS#151879
@github-actions github-actions bot removed the 6.topic: vim Advanced text editor label Feb 14, 2022
@crabtw
Copy link
Contributor Author

crabtw commented Feb 14, 2022

I think it is better to target staging here

Done.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Feb 14, 2022
@ofborg ofborg bot requested a review from 7c6f434c February 14, 2022 11:21
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 14, 2022
@Ericson2314 Ericson2314 merged commit 71c7eb2 into NixOS:staging Feb 14, 2022
@hmenke hmenke mentioned this pull request Feb 20, 2022
Closed
@hmenke
Copy link
Member

hmenke commented Feb 20, 2022

Would it be possible to backport this to 21.11?

@Ericson2314
Copy link
Member

Ericson2314 commented Feb 21, 2022

Sure!

@github-actions github-actions bot mentioned this pull request Feb 21, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

Successfully created backport PR #161137 for staging-21.11.

crabtw added a commit to crabtw/nixpkgs that referenced this pull request Sep 30, 2022
@crabtw
llvmPackages_{14, git}.clang: add nostdlibinc flag
44165d3 
Fix header search paths as NixOS#153963
@crabtw crabtw mentioned this pull request Sep 30, 2022
Merged
13 tasks
@rrbutani rrbutani mentioned this pull request Feb 14, 2023
Open
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
@reckenrode reckenrode mentioned this pull request Oct 20, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dtzWill dtzWill Awaiting requested review from dtzWill

@lovek323 lovek323 Awaiting requested review from lovek323

@primeos primeos Awaiting requested review from primeos

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@marsam marsam Awaiting requested review from marsam

@ttuegel ttuegel Awaiting requested review from ttuegel

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@aszlig aszlig Awaiting requested review from aszlig

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

1 more reviewer

@hmenke hmenke hmenke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

llvmPackages_13.libcxxStdenv has wrong header search paths

5 participants

@crabtw @7c6f434c @hmenke @Ericson2314 @rrbutani