Closed
Conversation
This derivation already doesn't build vigra's python bindings; the only use of python is the `bin/vigra-config` script that dependent packages can use to get compiler flags. I confirmed that this script works correctly on python3. Without building the python bindings, the numpy dependency is not used, so was removed. A `diff` between the old and new output directories shows that the only changes are in `bin/vigra-config`: the `#!` path to python and the absolute paths to the output directory that would change on any rebuild.
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This derivation already doesn't build vigra's python bindings; the only use of python is the
bin/vigra-configscript that dependent packages can use to get compiler flags. I confirmed that this script works correctly on python3. Without building the python bindings, the numpy dependency is not used, so was removed.A
diffbetween the old and new output directories shows that the only changes are inbin/vigra-config: the#!path to python and the absolute paths to the output directory that would change on any rebuild.Motivation for this change
Remove python2: #148779
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes