lziprecover: init at 1.22#153478
Merged
SuperSandro2000 merged 4 commits intoNixOS:stagingfrom Jan 27, 2022
Merged
Conversation
ofborg
bot
added
8.has: package (new)
c0bw3b
reviewed
Jan 16, 2022
Contributor
There was a problem hiding this comment.
It builds and runs properly.
One message during build though:
testing --reproduce...
warning: skipping --reproduce test: lzip not found or not the right version.
Try 'make LZIP_NAME=<name_of_lzip_executable> check'.
You need to pass lzip in checkInputs in order to run all possible tests during check phase.
According to the homepage and `COPYING` file inside the source archive.
It is not an issue if $CXX variable is always set to an absolute value, there is no need to set it conditionally.
Companion package to `lzip`
ofborg
bot
added
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
Member
|
We can either put this entire PR onto staging or only move the lzip things there because they cause to many rebuilds |
Member
|
We can either change the entire PR to target staging or only move the lzip changes to staging. |
Contributor
Author
|
I've retargeted the PR to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer is absent for the original package that's why I haven't put myself in here. I can add myself to both of them if needed
Motivation for this change
This is a data recovery tool for
lzipfiles. which I am depending on for my current job :)Things done
Tried cross-building to multiple platform successfully but didn't test any of the crossbuilt output. CFLAGS and co. are directly lifted over from the
lzipdefivation.sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes