Skip to content

hevm: unbreak on aarch64-linux#153344

Closed
arcz wants to merge 1 commit intoNixOS:masterfrom
arcz:unbreak-hevm
Closed

hevm: unbreak on aarch64-linux#153344
arcz wants to merge 1 commit intoNixOS:masterfrom
arcz:unbreak-hevm

Conversation

@arcz
Copy link
Member

@arcz arcz commented Jan 3, 2022

Motivation for this change

I did a few PRs (merged) to make hevm work on aarch64-linux so this is no longer needed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jan 3, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 3, 2022
@cdepillabout
Copy link
Member

cdepillabout commented Jan 3, 2022 •
edited
Loading

If you run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh it will regenerate the
pkgs/development/haskell-modules/hackage-packages.nix file and actually fix up the platform stuff. I force-pushed this change. Also, we generally target the haskell-updates branch for haskell-related changes, rather than master.

@ofborg build haskellPackages.hevm haskellPackages.sbv

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 3, 2022
cdepillabout pushed a commit that referenced this pull request Jan 4, 2022
@arcz @cdepillabout
hevm: unbreak on aarch64-linux
44a74d1 
(cherry picked from commit 1468f44)

This is from #153344.
@cdepillabout
Copy link
Member

cdepillabout commented Jan 4, 2022 •
edited
Loading

It looks like ofborg timed out on aarch64-linux before fully finishing the build of hevm and sbv, but it made it far enough that it appears to be working. Thanks!

I cherry-picked this as 44a74d1 in #152408.

@arcz arcz deleted the unbreak-hevm branch January 4, 2022 15:43
cdepillabout added a commit that referenced this pull request Jan 5, 2022
@cdepillabout
haskellPackages.crackNum: re-enable on aarch64-linux
312315f 
This should hopefully now be working on aarch64-linux since
sbv (one of crackNum's deps) is now working on aarch64-linux:
#153344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arcz @cdepillabout