Skip to content

slic3r: use boost172#153276

Merged
veprbl merged 1 commit intoNixOS:masterfrom
CRTified:slic3r-pinboost
Jan 3, 2022
Merged

slic3r: use boost172#153276
veprbl merged 1 commit intoNixOS:masterfrom
CRTified:slic3r-pinboost

Conversation

@CRTified
Copy link
Contributor

@CRTified CRTified commented Jan 2, 2022

This fixes the regression due to a boost version bump.
It pins the used version to boost172 (boost16x would also work).

Motivation for this change

slic3r doesn't build on master (and unstable), see #151469

I'm not the maintainer, so @bjornfor might want to check it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This fixes the regression due to a boost version bump.
It pins the used version to boost172.
@CRTified CRTified requested a review from bjornfor January 2, 2022 23:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 2, 2022
@veprbl veprbl mentioned this pull request Jan 3, 2022
54 tasks
@veprbl veprbl merged commit a253185 into NixOS:master Jan 3, 2022
@veprbl
Copy link
Member

veprbl commented Jan 3, 2022

Thank you!

@CRTified CRTified deleted the slic3r-pinboost branch January 3, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants