Remove applications that depend on python2Packages#153151
Merged
dotlambda merged 23 commits intoNixOS:masterfrom Jan 3, 2022
Merged
Remove applications that depend on python2Packages#153151dotlambda merged 23 commits intoNixOS:masterfrom
dotlambda merged 23 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
Member
|
Courtesy pings:
|
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
No objection from me for removing |
Member
Author
There is a failing test without it. ======================================================================
ERROR: testAnalyze (test_Handshake.TestHandshake)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/source/tests/test_Handshake.py", line 27, in testAnalyze
hs.analyze()
File "/build/source/wifite/model/handshake.py", line 127, in analyze
self.divine_bssid_and_essid()
File "/build/source/wifite/model/handshake.py", line 38, in divine_bssid_and_essid
pairs = self.pyrit_handshakes() # Find bssid/essid pairs that have handshakes in Pyrit
File "/build/source/wifite/model/handshake.py", line 109, in pyrit_handshakes
return Pyrit.bssid_essid_with_handshakes(
File "/build/source/wifite/tools/pyrit.py", line 28, in bssid_essid_with_handshakes
pyrit = Process(command, devnull=False)
File "/build/source/wifite/util/process.py", line 93, in __init__
self.pid = Popen(command, stdout=sout, stderr=serr, stdin=stdin, cwd=cwd, bufsize=bufsize)
File "/nix/store/rppr9s436950i1dlzknbmz40m2xqqnxc-python3-3.9.9/lib/python3.9/subprocess.py", line 951, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/nix/store/rppr9s436950i1dlzknbmz40m2xqqnxc-python3-3.9.9/lib/python3.9/subprocess.py", line 1821, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pyrit'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/build/source/tests/test_Handshake.py", line 29, in testAnalyze
exit()
File "/nix/store/rppr9s436950i1dlzknbmz40m2xqqnxc-python3-3.9.9/lib/python3.9/_sitebuiltins.py", line 26, in __call__
raise SystemExit(code)
SystemExit: NoneIt should be skipped because it is decorated with the following, but it isn't. @unittest.skipUnless(Process.exists('pyrit'), 'pyrit is missing')So I replaced that and it still tries to execute the test. diff --git a/pkgs/tools/networking/wifite2/default.nix b/pkgs/tools/networking/wifite2/default.nix
index 44227dcce2a..9463c1c20c9 100644
--- a/pkgs/tools/networking/wifite2/default.nix
+++ b/pkgs/tools/networking/wifite2/default.nix
@@ -24,6 +24,11 @@ python3.pkgs.buildPythonApplication rec {
})
];
+ postPatch = ''
+ substituteInPlace tests/test_Handshake.py \
+ --replace "@unittest.skipUnless(Process.exists('pyrit'), 'pyrit is missing')" "@unittest.skip"
+ '';
+
propagatedBuildInputs = [
aircrack-ng
wireshark-cliFeel free to push a fix. |
Contributor
|
@mweinelt I'm having trouble pushing my change to this branch. Either my permissions aren't sufficient or I'm doing it wrong. But feel free to cherry-pick this commit: danielfullmer@5a50edf |
Mic92
approved these changes
Jan 2, 2022
dotlambda
force-pushed
the
python2-removals
branch
from
05409da to
ce1da85
Compare
Member
|
Result of 1 package blacklisted:
2 packages built:
|
dotlambda
reviewed
Jan 2, 2022
Python2 user and unmaintained upstream since 2016.
Uses python2 and unmaintained in nixpkgs since introduced in 2018. Upstream still maintains it, but it isn't easy to package, so we'll remove it now.
Using python2 and abadoned upstream in 2020, last release in 2015.
Uses python2 and the upstream stopped maintaining it in 2017.
The maintainer hasn't interacted with this package since it was introduced in 2017.
Uses python2 and the upstream has abandoned the project.
Uses python2 and abandoned by upstream.
Uses python2 and abandoned by upstream in 2012.
Stuck on python2, the upstream added a note to the projectes REAMDE to watch out for a python3 version. Nothing ever came off it.
Uses python2 and abandoned by upstream.
Uses python2 and abandoned by upstream.
Uses python2 and the upstream homepage is abandoned, the download link is dead.
Requires python2 and no release in over two years to resolve the
situation.
```
./img2tiles.py -s font_interlace_variable.spec font_interlace_variable.tiles
File "/build/blastem-3d48cb0c28be/./img2tiles.py", line 78
print len(colors), 'distinct 9-bit colors in image'
^
SyntaxError: invalid syntax
```
Stuck on python2 and abandoned by upstream.
Stuck on python2 and last release in 2015.
Stuck on python2 and last release in 2010.
Stuck on python2 with last release in 2012.
> rawdog requires Python 2.7 or later, and not Python 3. Have it your way!
Stuck on python2 and unmaintained since 2015.
Stuck on python2 and abandoned since 2017.
> "Programming Language :: Python :: 2.7 :: Only",
The latter was removed because it is stuck on python2. Co-authored-by: Daniel Fullmer <[email protected]>
mweinelt
force-pushed
the
python2-removals
branch
from
ce1da85 to
94bb926
Compare
Member
|
Yes, look like |
Member
|
Should probably mention this in the release notes for 22.05 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A first batch of application removals as well as python3 ports. Looked for application that depend on python2Packages.
#148779
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes