NDN: fix builds after boost upgrade#152721
Merged
veprbl merged 1 commit intoNixOS:masterfrom Dec 31, 2021
Merged
Conversation
- updated derivations with the correct boost version - prepared check phases for unit tests. Some of them don't work on upstream and have already been reported years ago - checked that the produced software works as expected
ofborg
bot
added
11.by: package-maintainer
Member
|
Result of 3 packages built:
|
Member
|
Thank you! |
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesThe temporary pinning of boost versions in the
all-packages.nixfile did not catch dependant packages recursively.I updated the derivations pinning boost175.
Some tests may not be integrated (just as before this update) as they're failing in the upstream too.
This should partially fix #151469 , at least for
ndn-toolsandnfdpackages.