Skip to content

kmymoney: 5.1.1 -> 5.1.2#152521

Closed
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:kmymoney-5.1.2
Closed

kmymoney: 5.1.1 -> 5.1.2#152521
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:kmymoney-5.1.2

Conversation

@dotlambda
Copy link
Member

Motivation for this change

#148779

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested review from Mic92 and alyssais December 28, 2021 22:57
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work; KMyMoney doesn't seem to respect $PYTHONPATH.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does someone know enough about the interactions between C++ and Python to find out how to set $PYTHONPATH in https://github.com/KDE/kmymoney/blob/v5.1.2/kmymoney/plugins/weboob/interface/weboobinterface.cpp?

PyObject *sys = PyImport_ImportModule("sys");
PyObject *path = PyObject_GetAttrString(sys, "path");
+ PyObject *pythonpath = PyUnicode_FromString("@pythonpath@");
+ PyList_Append(path, pythonpath);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wonder why this doesn't work either.

@mweinelt mweinelt removed their request for review December 29, 2021 23:54
@mweinelt
Copy link
Member

Sorry, not my cup of tea.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 30, 2021
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 10, 2022
@dotlambda dotlambda closed this Apr 25, 2023
@dotlambda dotlambda deleted the kmymoney-5.1.2 branch April 25, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants