libpulseaudio: fix aarch64-darwin build#152371
Merged
bobby285271 merged 1 commit intoNixOS:masterfrom Jan 2, 2022
Merged
Conversation
Removes darwin Libc buildInput, which does not appear to be needed on x86_64, and which does not support aarch64 at all (too old)
mikroskeem
force-pushed
the
darwin-fix-libpulseaudio-aarch64
branch
from
1b6592d to
e9f4ecd
Compare
mikroskeem
changed the title
13 tasks
ofborg
bot
added
6.topic: darwin
Member
|
Wait... I think this should target staging...? Edit: Reverted in #153176, @mikroskeem I am very sorry I didn't check that. Would you like to cherry-pick this and open a new PR that target |
Member
Author
|
Sure thing. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes darwin Libc buildInput, which does not appear to be needed on
x86_64, and which does not support aarch64 at all (too old)
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes