webp-pixbuf-loader: init at 0.0.3#152312
Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom Oct 6, 2022
Merged
Conversation
12a2841 to
73367a6
Compare
Contributor
legendofmiracles
left a comment
There was a problem hiding this comment.
The default.nix could need some formatting with nixpkgs-fmt
73367a6 to
6d35a26
Compare
bobby285271
reviewed
Dec 27, 2021
bobby285271
reviewed
Dec 27, 2021
9812bb5 to
14cef86
Compare
687cbe6 to
263ee9c
Compare
Contributor
Author
|
Fixed thumbnailer |
bobby285271
reviewed
Dec 31, 2021
Contributor
|
Versopm 0.0.5 released :) |
maintainers/maintainer-list.nix
Outdated
Member
There was a problem hiding this comment.
It would be cool if you would use an email address outside of github.
Member
There was a problem hiding this comment.
Suggested change
| prePatch = '' | |
| postPatch = '' |
eccf48c to
0baa480
Compare
Contributor
Author
|
Sorry I was dead for all this time. Here are the revisions you requested. |
Contributor
|
Looks like there's a merge conflict? |
0baa480 to
fa45eec
Compare
SuperSandro2000
approved these changes
Oct 1, 2022
Member
SuperSandro2000
left a comment
There was a problem hiding this comment.
LGTM with those minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packaging https://github.com/aruiz/webp-pixbuf-loader , which allows programs using gdk-pixbuf to load webp images.
At this time this package isn't much use. The only programs making use of gdk-pixbuf are GTK apps, and
wrapGAppsHookputs them in a wrapper that overrides the$GDK_PIXBUF_MODULE_FILEenvironment variable. See #42562 (comment)Still, it works with
eogandristretto:services.xserver.gdk-pixbuf.modulePackages = [pkgs.webp-pixbuf-loader];alternatively, you can find this package in
nur.repos.cwyc.webp-pixbuf-loader$GDK_PIXBUF_MODULE_FILEcat $(which eog) | sed -e "s/export GDK_PIXBUF_MODULE_FILE=.*//" > ./wrapper.shcurl https://www.gstatic.com/webp/gallery/1.webp -o sample.webp./wrapper.sh sample.webp(If your terminal program also launches through the GTK wrapper, then
$GDK_PIXBUF_MODULE_FILEmight have already been overwritten. In that case you'd have to find what it would have been usingnixos-option environment.variables, and set it manually before running.)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes