Skip to content

webp-pixbuf-loader: init at 0.0.3#152312

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
cwyc:gdk-pixbuf-webp
Oct 6, 2022
Merged

webp-pixbuf-loader: init at 0.0.3#152312
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
cwyc:gdk-pixbuf-webp

Conversation

@cwyc
Copy link
Contributor

@cwyc cwyc commented Dec 27, 2021

Motivation for this change

Packaging https://github.com/aruiz/webp-pixbuf-loader , which allows programs using gdk-pixbuf to load webp images.

At this time this package isn't much use. The only programs making use of gdk-pixbuf are GTK apps, and wrapGAppsHook puts them in a wrapper that overrides the $GDK_PIXBUF_MODULE_FILE environment variable. See #42562 (comment)

Still, it works with eog and ristretto:

  • configure this package in your configuration.nix
    services.xserver.gdk-pixbuf.modulePackages = [pkgs.webp-pixbuf-loader];
    alternatively, you can find this package in nur.repos.cwyc.webp-pixbuf-loader
  • copy the wrapper script to your working directory and remove the line setting $GDK_PIXBUF_MODULE_FILE
    cat $(which eog) | sed -e "s/export GDK_PIXBUF_MODULE_FILE=.*//" > ./wrapper.sh
  • get a sample file if you have none
    curl https://www.gstatic.com/webp/gallery/1.webp -o sample.webp
  • launch it
    ./wrapper.sh sample.webp
    (If your terminal program also launches through the GTK wrapper, then $GDK_PIXBUF_MODULE_FILE might have already been overwritten. In that case you'd have to find what it would have been using nixos-option environment.variables, and set it manually before running.)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@legendofmiracles legendofmiracles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default.nix could need some formatting with nixpkgs-fmt

@cwyc cwyc force-pushed the gdk-pixbuf-webp branch 3 times, most recently from 9812bb5 to 14cef86 Compare December 27, 2021 04:29
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 27, 2021
@cwyc cwyc force-pushed the gdk-pixbuf-webp branch 4 times, most recently from 687cbe6 to 263ee9c Compare December 31, 2021 04:56
@cwyc
Copy link
Contributor Author

cwyc commented Dec 31, 2021

Fixed thumbnailer

@onny
Copy link
Contributor

onny commented Jun 5, 2022

Versopm 0.0.5 released :)

VergeDX
VergeDX approved these changes Jun 16, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if you would use an email address outside of github.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prePatch = ''
postPatch = ''

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 26, 2022
@cwyc
Copy link
Contributor Author

cwyc commented Sep 27, 2022

Sorry I was dead for all this time. Here are the revisions you requested.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2022
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 27, 2022
@onny
Copy link
Contributor

onny commented Sep 28, 2022

Looks like there's a merge conflict?

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 30, 2022
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with those minor changes

@bobby285271 bobby285271 added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Oct 1, 2022
@cwyc cwyc force-pushed the gdk-pixbuf-webp branch from fa45eec to 160f8e9 Compare October 2, 2022 04:10
@bobby285271 bobby285271 removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants