Closed
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 6 packages built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jtojnar
requested changes
Jan 26, 2022
Member
jtojnar
left a comment
jtojnar
left a comment
There was a problem hiding this comment.
Looking at changelog,
- you need to remove the
pulsemeson flag (https://gitlab.freedesktop.org/spice/spice-gtk/-/merge_requests/33) - capabilities seem to be set correctly in the NixOS module (https://gitlab.freedesktop.org/spice/spice-gtk/-/merge_requests/42) we might have actually switched to capabilities too early in #97826.
- but we will definitely need
-Dusb-acl-helper-dir=${placeholder "out"}/binmeson flag since we rely on the ACL helper being onPATH. (https://gitlab.freedesktop.org/spice/spice-gtk/-/merge_requests/45) - we might want to add wayland dependencies (https://gitlab.freedesktop.org/spice/spice-gtk/-/merge_requests/45) – perhaps they are propagated by something
tadeokondrak
force-pushed
the
spice-gtk-update-0.39
branch
from
73fa3ea to
3896ee6
Compare
Member
|
Looks like pulse was not the only removed option: |
tadeokondrak
force-pushed
the
spice-gtk-update-0.39
branch
from
3896ee6 to
9b036ab
Compare
tadeokondrak
force-pushed
the
spice-gtk-update-0.39
branch
from
9b036ab to
54fd365
Compare
Contributor
Author
Huh, I didn't see this because it only showed up as a warning. I fixed some other issues:
|
Member
|
(We have just merged new Meson version that is more strict.) |
Contributor
Author
|
Superseded by #159340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This update fixes issues I've had with display scaling.i
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes