Skip to content

Fix ghc c++ exceptions#152037

Closed
roberth wants to merge 2 commits intoNixOS:haskell-updatesfrom
hercules-ci:fix-ghc-c++-exceptions
Closed

Fix ghc c++ exceptions#152037
roberth wants to merge 2 commits intoNixOS:haskell-updatesfrom
hercules-ci:fix-ghc-c++-exceptions

Conversation

@roberth
Copy link
Member

@roberth roberth commented Dec 24, 2021 •
edited
Loading

Motivation for this change

Fix C++ exception handling in darwin executables linked by GHC.

-fcompact-unwind should probably be applied to all test suites and executables that interface with C++.
Perhaps, after a decade of __compact_unwind existing, it should become the default, but I don't know if the ecosystem is ready for it, so it's opt-in for now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 24, 2021
@ofborg ofborg bot requested a review from guibou December 24, 2021 20:34
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 24, 2021
@roberth roberth mentioned this pull request Dec 24, 2021
Closed
@cdepillabout cdepillabout mentioned this pull request Dec 31, 2021
Merged
@sternenseemann
Copy link
Member

sternenseemann commented Jan 4, 2022

I don't think it necessarily makes sense to fix such a GHC deficiency downstream, especially not before upstream has accepted the patch.

@roberth roberth mentioned this pull request Mar 31, 2022
Merged
13 tasks
@roberth
Copy link
Member Author

roberth commented Mar 31, 2022

not before upstream has accepted the patch.

It has been accepted in 9.4, backported to 9.2.
9.0 has only seen two commits backported since its latest release 3 months ago, so I'm not getting my hopes up for an upstream backport.

Following this up in #166571

@roberth roberth closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@domenkozar domenkozar Awaiting requested review from domenkozar

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@guibou guibou Awaiting requested review from guibou

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roberth @sternenseemann