Skip to content

meta.updateWalker: remove because it is not used#151363

Merged
SuperSandro2000 merged 5 commits intoNixOS:masterfrom
Stunkymonkey:doc-updateWalker
Jan 27, 2022
Merged

meta.updateWalker: remove because it is not used#151363
SuperSandro2000 merged 5 commits intoNixOS:masterfrom
Stunkymonkey:doc-updateWalker

Conversation

@Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 19, 2021

Motivation for this change

#103997 removing the documentation about meta.updateWalker

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Dec 19, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 19, 2021
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Dec 19, 2021

can someone help me in how to better document this? is running nixos/doc/manual/md-to-db.sh needed?

@Mic92 Mic92 requested a review from ryantm December 20, 2021 07:20
@ryantm
Copy link
Member

ryantm commented Dec 21, 2021

Shouldn't this be in the same PR that removes update-walker.sh? (Assuming we actually do want to remove it, I don't know about it.)

is running nixos/doc/manual/md-to-db.sh needed?

No, that's only needed if you change the NixOS docs, not the nixpkgs ones like you have here.

@Stunkymonkey Stunkymonkey changed the title meta.updateWalker: remove doc, because it is not used meta.updateWalker: remove because it is not used Dec 21, 2021
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Dec 21, 2021

sure i can include the removal into a single PR. I thought more of splitting it up into multiple PRs

@Stunkymonkey Stunkymonkey force-pushed the doc-updateWalker branch 2 times, most recently from beed247 to 0cb3050 Compare December 25, 2021 16:17
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Dec 25, 2021

i just notice, that all additional changes i did are not very helpful for reviewing the PR. Should I remove them?

@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 25, 2021
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Jan 12, 2022

i removed all the changes, that were not necessary

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 12, 2022
@Stunkymonkey Stunkymonkey force-pushed the doc-updateWalker branch 2 times, most recently from 5d9f1cf to 86233aa Compare January 16, 2022 17:43
@Stunkymonkey Stunkymonkey requested a review from nh2 January 18, 2022 11:44
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 24, 2022
Open
7 tasks
SuperSandro2000
SuperSandro2000 requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also drop https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/check-meta.nix#L239 and https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/check-meta.nix#L247 ?

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jan 26, 2022
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Jan 26, 2022

is now removed in the last commit

@SuperSandro2000 SuperSandro2000 merged commit 27cccd4 into NixOS:master Jan 27, 2022
@zowoq
Copy link
Contributor

zowoq commented Jan 30, 2022

This seems to have missed a couple of files?

nixpkgs/pkgs/development/tools/misc/luarocks/default.upstream

Line 1 in bcd452a

url http://luarocks.org/releases/

nixpkgs/pkgs/servers/nosql/apache-jena/fuseki-binary.upstream

Line 1 in 30d4848

name apache-jena-fuseki

This is still used in one place, I'd suggest moving into the the same directory.

nixpkgs/pkgs/build-support/upstream-updater/urls-from-page.sh

Line 1 in bcd452a

#! /bin/sh

nixpkgs/pkgs/development/lisp-modules/from-quicklisp/barebones-quicklisp-expression.sh

Line 54 in 5a17134

version="$("$(dirname "$0")/../../../build-support/upstream-updater/urls-from-page.sh" "$url/releases/" | grep /tag/ | head -n 1 | xargs -l1 basename)"

Can also remove these from .editorconfig:

nixpkgs/.editorconfig

Lines 70 to 72 in 3540d00

[pkgs/build-support/upstream-updater/**]
indent_style = unset
trim_trailing_whitespace = unset

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 30, 2022

@Stunkymonkey can you please take a look at the above comment? I currently miss the time to do that.

This was referenced Jan 30, 2022
Merged
Merged
@Stunkymonkey Stunkymonkey deleted the doc-updateWalker branch February 14, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ryantm ryantm Awaiting requested review from ryantm

@nh2 nh2 Awaiting requested review from nh2

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Stunkymonkey @ryantm @zowoq @SuperSandro2000