Skip to content

python3Packages.sslyze: 4.1.0 -> 5.0.0#150567

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
veehaitch:sslyze-5.0.0
Dec 14, 2021
Merged

python3Packages.sslyze: 4.1.0 -> 5.0.0#150567
mweinelt merged 1 commit intoNixOS:masterfrom
veehaitch:sslyze-5.0.0

Conversation

@veehaitch
Copy link
Member

@veehaitch veehaitch commented Dec 13, 2021 •
edited
Loading

Motivation for this change

Bump version, #150320

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@veehaitch veehaitch requested a review from mweinelt December 13, 2021 16:49
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 13, 2021
@veehaitch
Copy link
Member Author

veehaitch commented Dec 13, 2021

Result of nixpkgs-review pr 150567 run on x86_64-linux 1

2 packages built:
  • python38Packages.sslyze
  • sslyze (python39Packages.sslyze)

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 13, 2021
@mweinelt
Copy link
Member

mweinelt commented Dec 14, 2021

I assume you've set NIXPKGS_ALLOW_INSECURE=1? Is that intentional?

@veehaitch
Copy link
Member Author

veehaitch commented Dec 14, 2021

Please refer to #144939 for the rationale.

mweinelt
mweinelt approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

@mweinelt mweinelt merged commit 120c6f8 into NixOS:master Dec 14, 2021
@c0bw3b c0bw3b mentioned this pull request Jan 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veehaitch @mweinelt