aflplusplus: qemu: move to python3#150242
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Dec 11, 2021
Merged
Conversation
QEMU 3.1 already had support for building with python3, so this should be a change that doesn't have any effect on the produced binaries. Python2 removal tracking issue: NixOS#148779
Contributor
Author
|
cc @risicle |
Member
|
Build fails for me, also for different reasons: |
Member
|
@GrahamcOfBorg build aflplusplus |
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
The cmocka thing can probably be ignored, but the failure in the tests is not great :/. Not sure why that happens, it works on ofborg and on my machine, so it's some impurity somewhere. |
Member
|
I build this on a 64 core machine. Maybe a parallelism issue? |
Member
|
It seems to build with less cores. |
Contributor
|
|
Contributor
Author
|
Probably a race then, hydra builders won't get 64 cores typically I guess, so it'll be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
QEMU 3.1 already had support for building with python3, so this should
be a change that doesn't have any effect on the produced binaries.
I checked with diffoscope and I don't see anything that has changed, so presumably this is all ok.
Python2 removal tracking issue: #148779
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)