Merged
Conversation
ofborg
bot
added
8.has: clean-up
thiagokokada
approved these changes
Dec 9, 2021
thiagokokada
previously requested changes
Dec 9, 2021
Contributor
thiagokokada
left a comment
thiagokokada
left a comment
There was a problem hiding this comment.
Package seems to build fine on x86_64-linux.
thiagokokada
reviewed
Dec 9, 2021
Contributor
thiagokokada
left a comment
thiagokokada
left a comment
There was a problem hiding this comment.
Also, it is missing a alias on pkgs/top-level/aliases.nix.
Member
Author
Does it run? |
The package was broken, depreciated and was using python2 NixOS#148779
magnetophon
force-pushed
the
linuxband
branch
from
a8cf635 to
9cc9963
Compare
Member
Author
Not anymore! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package was broken, depreciated and was using python2
#148779
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes