Skip to content

kmod: switch the priority of module dirs#149244

Merged
Artturin merged 2 commits intoNixOS:stagingfrom
Artturin:kmodpathpriority
Dec 9, 2021
Merged

kmod: switch the priority of module dirs#149244
Artturin merged 2 commits intoNixOS:stagingfrom
Artturin:kmodpathpriority

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Dec 7, 2021

make "/run/booted-system/kernel-modules" be searched first

Fixes #146383
modprobe: ERROR: could not insert 'zram': Invalid argument

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin
kmod: switch the priority of module dirs
453968c 
make "/run/booted-system/kernel-modules" be searched first

Fixes NixOS#146383
modprobe: ERROR: could not insert 'zram': Invalid argument
This was referenced Dec 7, 2021
Closed
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 7, 2021
@Artturin Artturin changed the base branch from master to staging December 8, 2021 00:50
@Artturin Artturin requested a review from abbradar December 8, 2021 01:56
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Dec 8, 2021
pennae
pennae approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works

@Artturin Artturin merged commit 57013fb into NixOS:staging Dec 9, 2021
@Artturin Artturin deleted the kmodpathpriority branch December 9, 2021 03:49
@github-actions github-actions bot mentioned this pull request Dec 9, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Successfully created backport PR #149777 for staging-21.11.

@Artturin Artturin mentioned this pull request Apr 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pennae pennae pennae approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zram: modprobe: ERROR: could not insert 'zram': Invalid argument

2 participants

@Artturin @pennae