Skip to content

julia: switch from python2 to python3#149177

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
garrison:julia-python3
Dec 7, 2021
Merged

julia: switch from python2 to python3#149177
7c6f434c merged 1 commit intoNixOS:masterfrom
garrison:julia-python3

Conversation

@garrison
Copy link
Member

@garrison garrison commented Dec 7, 2021

Julia does not actually require python2; it just requires any version of python that is equal to or greater than 2.7.

This changes the python dependency from python2 to python3.

I have verified that julia-1.0 builds with this change. julia-1.5 is marked as broken in nixpkgs, so I have not tested it (but I would be very surprised if this change broke it further).

Motivation for this change

#148779

Things done
  • Built on platform(s)
    • x86_64-linux (julia-1.0 only)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [xcccccchulekhgdivjgnetcbtfbhluvhfrevcgfrfbfvt
  • ] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Julia does not actually require python2; it just requires any version of python
[that is equal to or greater than 2.7](https://github.com/JuliaLang/julia/blob/master/doc/src/devdocs/build/build.md#required-build-tools-and-external-libraries).

This changes the python dependency from python2 to python3.

I have verified that julia-1.0 builds with this change.  julia-1.5 is marked as broken
in nixpkgs, so I have not tested it (but I would be very surprised if this change
broke it further).

Motivated by NixOS#148779
@garrison
Copy link
Member Author

garrison commented Dec 7, 2021

CC @7c6f434c, @rbvermaa

@ofborg ofborg bot requested review from 7c6f434c and rbvermaa December 7, 2021 00:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 7, 2021
@7c6f434c 7c6f434c merged commit 71dfb6b into NixOS:master Dec 7, 2021
@garrison garrison deleted the julia-python3 branch December 7, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants